Code review for a dotfiles manager?

blov · · 388 次点击    
这是一个分享于 的资源,其中的信息可能已经有所发展或是发生改变。
<p>Hello dear gophers! A newbie here.</p> <p>So, I&#39;m gonna release the first version of my dotfiles manager and before releasing a bunch of junk as something finished to the public (not going to put examples here :P) I want it to look and work properly, can you review my code please?</p> <p>The repo is here: <a href="https://github.com/feddasch/dotto">https://github.com/feddasch/dotto</a></p> <p>Thank you :)</p> <hr/>**评论:**<br/><br/>itsamemmario: <pre><p>I like it, very clean. The one thing that bothers me is your tiny utils package. In general it&#39;s not a good idea do have utils package in your repo. It&#39;s often just a bunch of functions for which you didn&#39;t take the time to find their right place. For example utils.Run is used only once in the cmd package. In my mind it&#39;s fine in the cmd package. Hope that helps Cheers</p></pre>feddasch: <pre><p>Thanks, I&#39;m planning to drop the dependency on the git command and replace it with the <a href="https://github.com/src-d/go-git" rel="nofollow">src-d/go-git</a> library after releasing v1.0 so util.Run and util.Git will no longer be necessary, I&#39;ll nuke util.FileIsLink later.</p></pre>

入群交流(和以上内容无关):加入Go大咖交流群,或添加微信:liuxiaoyan-s 备注:入群;或加QQ群:692541889

388 次点击  
加入收藏 微博
0 回复
暂无回复
添加一条新回复 (您需要 登录 后才能回复 没有账号 ?)
  • 请尽量让自己的回复能够对别人有帮助
  • 支持 Markdown 格式, **粗体**、~~删除线~~、`单行代码`
  • 支持 @ 本站用户;支持表情(输入 : 提示),见 Emoji cheat sheet
  • 图片支持拖拽、截图粘贴等方式上传