Writing a client for Phabricator's Conduit API. Code review?

<p>This is my first time writing an API client in Go and I&#39;d appreciate any feedback you guys have. It&#39;s still fairly small but has the basics of connecting, authenticating, and a few endpoint calls in place.</p> <p>I think I&#39;m doing things in an idiomatic way but want to make sure.</p> <p>Also, if anyone is interested in contributing to this let me know!</p> <p>Docs: <a href="http://godoc.org/github.com/jpoehls/go-conduit">http://godoc.org/github.com/jpoehls/go-conduit</a><br/> Code: <a href="http://github.com/jpoehls/go-conduit">http://github.com/jpoehls/go-conduit</a> (README has usage examples)</p> <p><strong>Update</strong>: I should mention that my tests are basically non-existent at this point. I plan to flush them out but they are just a sanity check for now.</p> <hr/>**评论：**<br/><br/>Ainar-G: <pre><p>Disclaimer: I&#39;ve never worked with Conduit API, so I can&#39;t judge the correctness of your code. As for the style, it seems all right apart from a couple of nits:</p> <ul> <li><p>s/Uri/URI/ in your <a href="http://godoc.org/github.com/jpoehls/go-conduit#PHIDResult">PHIDResult</a></p></li> <li><p><code>error</code> variables are usually called <code>err</code>, not <code>e</code>.</p></li> <li><p><code>IsConduitError</code> looks useless; <code>ConduitError</code> is exported, so users can write a type assertion for themselves.</p></li> </ul></pre>silent__thought: <pre><p>Thanks! I fixed the things you mentioned but left <code>IsConduitError</code> around for now. Will probably remove soon though since I agree it is is pretty useless.</p></pre>space-llama: <pre><p>It&#39;s not the worst. <code>call()</code> in <code>dialer.go</code> could probably be moved into utilities? There are a few places where you could compress some lines by making the call and checking the error in the <code>if</code> statement. Like, change <a href="https://github.com/jpoehls/go-conduit/blob/master/phid.go#L30" rel="nofollow">this</a> to be like <a href="https://github.com/jpoehls/go-conduit/blob/master/phid.go#L66" rel="nofollow">this</a>. There also seems to be an opportunity to use the reflect package to generalize all of the api endpoints + results but I&#39;m sure there are plenty of good reasons not to.</p></pre>silent__thought: <pre><p>Thanks! Good catch on my <code>if</code> statements. I&#39;m still getting use to the shorthand version and forget to use it most of the time.</p> <p>I&#39;ve cleaned those up and moved <code>call()</code> as well.</p></pre>PsyWolf: <pre><p>If you&#39;re familiar with python, you should check out the arcyon tool in <a href="https://github.com/bloomberg/phabricator-tools" rel="nofollow">https://github.com/bloomberg/phabricator-tools</a> . You can use as an example conduit client to check your implementation against.</p></pre>