I was handed 'ttlcache' on github and would welcome a review or tips on further testing

xuanbao · 2017-05-20 04:00:03 · 639 次点击    
这是一个分享于 2017-05-20 04:00:03 的资源,其中的信息可能已经有所发展或是发生改变。

I was handed over a repository on github, https://github.com/ReneKroon/ttlcache having a ttlcache in which i fixed multiple bugs as i was running into them in app i am now maintaining at work. Im mainly interested in better or different test cases. I identified that the benchmarks are only single threaded for example, but am looking for more tips to improve. Share your thoughts!


评论:

jeffrallen:

Here's a totally random thing I noticed while taking a quick look:

https://github.com/ReneKroon/ttlcache/blob/master/priority_queue_test.go#L26

Checking types should be done with a type assertion, not with %T. Checkign with %T is slower, and also would break in a confusing way if the code was refactored. (If the code was refactored, a type assertion would likely immediately not compile, because the type would not exist anymore.)

-jeff

RwKroon:

I will fix it.


入群交流(和以上内容无关):加入Go大咖交流群,或添加微信:liuxiaoyan-s 备注:入群;或加QQ群:692541889

639 次点击  
加入收藏 微博
0 回复
暂无回复
添加一条新回复 (您需要 登录 后才能回复 没有账号 ?)
  • 请尽量让自己的回复能够对别人有帮助
  • 支持 Markdown 格式, **粗体**、~~删除线~~、`单行代码`
  • 支持 @ 本站用户;支持表情(输入 : 提示),见 Emoji cheat sheet
  • 图片支持拖拽、截图粘贴等方式上传